NO-ISSUE: Adjust CI for all branches #2433
Conversation
| @@ -1,4 +1,4 @@ | |||
| FROM cruizba/ubuntu-dind:noble-26.1.3 | |||
| FROM cruizba/ubuntu-dind:jammy-26.1.3 | |||
There was a problem hiding this comment.
What's the difference between "noble" and "jammy"? :D
There was a problem hiding this comment.
noble is ubuntu 24.04 and jammy is ubuntu 22.04
.ci/jenkins/Jenkinsfile.ci-main
Outdated
| @@ -54,8 +53,7 @@ pipeline { | |||
| "https://github.com/${pipelineVars.githubRepositoryOrg}/${pipelineVars.githubRepositoryName}.git", | |||
| "${pipelineVars.kieToolsBotGithubCredentialsId}" | |||
| ) | |||
|
|
|||
| BUILD_IMAGE_REQUIRED = githubUtils.fileIsInChangeset('incubator-kie-tools-ci-build.Dockerfile') | |||
| BUILD_IMAGE_REQUIRED = (BRANCH_NAME != 'main' || githubUtils.fileIsInChangeset('incubator-kie-tools-ci-build.Dockerfile')) | |||
There was a problem hiding this comment.
Is BRANCH_NAME != 'main' for the case of new branches? If so, maybe we could have a way to check if a tag for that stream exists or not, right? Because otherwise, all PRs for non-main branches will re-build the image, no?
There was a problem hiding this comment.
Your assumption is correct. The way we filter the job run is by adding a regular expression: (main|\d{1,2}\.\d{1,2}\.x) in the job configuration triggers.
There was a problem hiding this comment.
Right, so we need to change that... otherwise the new branches will unnecessarily build the image every time...
There was a problem hiding this comment.
As I mentioned in my previous comment we already have the regular expression filter applied in the jobs, so they will only be triggered for the main branch and for the branches that have their names following this pattern: 0.0.x
rodrigonull
force-pushed
the
fix-dockerhub-image-names
branch
from
7df7c1b to
048cbe7
Compare
In this PR: